[PATCH] D62929: [GWP-ASan] Integration with Scudo [5].

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added a comment.

I think it's good from the integration perspective.
The only potential concern I have is the specific use of the TLS variables in GWP-ASan which might not work everywhere here (eg: if a platform is using emutls as TLS as it uses malloc() internally).
Have you tested that locally with an Android emulator?



================
Comment at: compiler-rt/test/scudo/lit.cfg:54
+if config.gwp_asan:
+  gwp_asan_options = 'Enabled=0'
+  config.environment['GWP_ASAN_OPTIONS'] = gwp_asan_options
----------------
nit: do you need the extra variable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62929/new/

https://reviews.llvm.org/D62929