[PATCH] D62901: [MIPS GlobalISel] Select floor and ceil

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 13:10:25 PDT 2019


atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:279
+    assert((Size == 32 || Size == 64) && "Unsupported size");
+    return Size == 64 ? RTLIB::CEIL_F64: RTLIB::CEIL_F32;
+  case TargetOpcode::G_FFLOOR:
----------------
Add space before colon.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:282
+    assert((Size == 32 || Size == 64) && "Unsupported size");
+    return Size == 64 ? RTLIB::FLOOR_F64: RTLIB::FLOOR_F32;
   }
----------------
Ditto.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62901/new/

https://reviews.llvm.org/D62901





More information about the llvm-commits mailing list