[PATCH] D62910: [DAGCombine] MergeConsecutiveStores - improve non-temporal load\store handling (PR42123)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 11:50:24 PDT 2019


RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15600
+
+      MachineMemOperand::Flags StMMOFlags =
+          IsNonTemporalStore ? MachineMemOperand::MONonTemporal
----------------
niravd wrote:
> Looks like we were erroneously transferring dereferencable from load to store on merge before. I think we need to do a store version of the isDereferencable calculation or we'll only preserve it on truncstores. 
Were we? The getStore() didn't use any MMO flags before.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62910/new/

https://reviews.llvm.org/D62910





More information about the llvm-commits mailing list