[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

Leonard Chan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 10:11:15 PDT 2019


leonardchan added a comment.

In D62225#1519394 <https://reviews.llvm.org/D62225#1519394>, @efriedma wrote:

> Are the behavior differences between the newpm alwaysinliner and the oldpm alwaysinliner intentional?  Specifically, the differences in pass remarks, and the differences in the treatment of the alwaysinline attribute seem suspect.  (I'm not that interested in the different bitcasts and different order of inline allocas, although that might be nice to fix if it's a small change.)


This is something for @chandlerc to answer, but I think based off D23299 <https://reviews.llvm.org/D23299> the different treatment of `alwaysinline` was intentional and the other aspects of it that this patch addresses like the `AddAlignmentAssumptions` are probably things that were overlooked at the time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62225/new/

https://reviews.llvm.org/D62225





More information about the llvm-commits mailing list