[PATCH] D62532: [AIX] Implement function descriptor on SDAG

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:490
+bool TargetPassConfig::willInitMCObjectFile(LLVMTargetMachine &TM) {
+  // Always lower target object file for MIR output on AIX.
+  if (TM.getTargetTriple ().isOSAIX())
----------------
Should we explain the rationale here?


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:491
+  // Always lower target object file for MIR output on AIX.
+  if (TM.getTargetTriple ().isOSAIX())
+    return true;
----------------
Remove the extra space after `getTargetTriple`.


================
Comment at: llvm/test/CodeGen/PowerPC/test_call_aix.ll:1
-; RUN: llc -mtriple powerpc-ibm-aix-xcoff -stop-after=machine-cp < %s | \
+; RUN: llc -mtriple powerpc-ibm-aix-xcoff -stop-after=machine-cp -init-MC < %s | \
 ; RUN: FileCheck --check-prefix=32BIT %s
----------------
The `-init-MC` is no longer needed now; right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62532/new/

https://reviews.llvm.org/D62532