[PATCH] D62604: [CodeGen] Generic Hardware Loop Support

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

> Made mightUseCTR into a private method. I tried static but since it uses many PPCTTIImpl members it just makes sense to have it as part of the class.

Thanks, sounds good.



================
Comment at: lib/Analysis/TargetTransformInfo.cpp:135
+  LLVMContext &C = L->getHeader()->getContext();
+  CountType = Type::getInt32Ty(C);
+  NumElements = ConstantInt::get(CountType, 1);
----------------
I'm unclear on the rationale for this default initialization. Is there really value here, or should we just set these to nullptr or similar?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62604/new/

https://reviews.llvm.org/D62604