[PATCH] D62478: [LV] Wrap LV illegality reporting in a function. NFC.

[Pavel Samolysov via Phabricator via llvm-commits]

psamolysov updated this revision to Diff 203123.
psamolysov added a comment.

I've updated the diff in the following way:

  - The method `reportVectorizationFailure` was broken into two, the helper function 'debugVectorizationFailure` that writes a message to `dbgs()` and prints the instruction that prevents vectorization if any.
- The method `reportVectorizationFailure` is saved, but the method `createMissedAnalysis` was removed from the `LoopVectorizationLegality` class, so `reportVectorizationFailure` just replaces the `createMissedAnalysis` one.

Because the number of method declared in the `LoopVectorizationLegality` class has not been changed, I think the solution can be accepted: the main objection - we not require additional private methods in class' header - could be considered as handled. Having a private method with access to the class' members: `TheLoop`, `ORE`, and `Hints` looks better than a helper method with a lot of parameters (the same loop, ORE, Hints).

@fhahn @hsaito @rengolin What are your opinions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62478/new/

https://reviews.llvm.org/D62478

Files:
  llvm/include/llvm/Transforms/Vectorize/LoopVectorizationLegality.h
  llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62478.203123.patch
Type: text/x-patch
Size: 20897 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190605/c6552cab/attachment.bin>