[PATCH] D62884: [lld] Explicitly ignore comdat groups when parsing LTO object

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1506
     auto *Obj = cast<ObjFile<ELFT>>(File);
-    Obj->parse(DummyGroups);
+    Obj->parse(/*IgnoreComdats*/ true);
     for (Symbol *Sym : Obj->getGlobalSymbols())
----------------
fyi, the usual style is `/*IgnoreComdats=*/true` (with no space and a =): for `true` it doesn't make a big difference, but for `false` it's not clear without the `=` if the comment means "set IgnoreComdats to false, that is they are not ignored" or "passing false here _means_ IgnoreComdats, that is passing false means they _are_ ignored".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62884/new/

https://reviews.llvm.org/D62884