[PATCH] D62848: [llvm-objdump] - Disassemble non-executable sections if specifically requested.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 03:18:50 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one minor nit.



================
Comment at: test/tools/llvm-objdump/X86/section-filter-disasm.test:4
+## By default, only executable sections are disassembled,
+## but with use of --section flag, we can change this behavior.
+## Show that llvm-objdump can disassemble the specified sections.
----------------
with use of -> with the use of the


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62848/new/

https://reviews.llvm.org/D62848





More information about the llvm-commits mailing list