[PATCH] D61600: [DebugInfo] More precise variable range for stack locations

Wed Jun 5 03:18:49 PDT 2019

NikolaPrica added a comment.

In D61600#1527581 <https://reviews.llvm.org/D61600#1527581>, @aprantl wrote:

> In D61600#1527182 <https://reviews.llvm.org/D61600#1527182>, @dstenb wrote:
>
> > In D61600#1527114 <https://reviews.llvm.org/D61600#1527114>, @NikolaPrica wrote:
> >
> > > > Have you tested the performance when compiling Clang with ASAN enabled to make sure we're not accidentally regressing because of the more thorough single-location check?
> > >
> > > I've built LLVM with '-DLLVM_USE_SANITIZER=Address' using downloaded clang binary to produce private clang binary. I've run tests and compiled latest version of gdb with new private binary and I didn't see any regression there. Is that what you meant?
> >
> >
> > I think that the idea was to see if this patch increases the compilation time when building such a Clang binary.
> >
> > (Just make sure to use the RelWithDebInfo build type also.)
>
>
> Yes. Enabling ASAN on a large C++ code base such as Clang is a great way to see compiler performance problems.
>  Can you post the output of "ninja clean && time ninja clang" before and after applying your patch to the *host* compiler?

Thanks for clarification!

before
======

real	46m29,670s
user	325m27,488s
sys	6m17,255s

after
=====

real	46m41,562s
user	326m16,497s
sys	6m18,981s

Considering user + sys there is 0.25% increment with patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61600/new/

https://reviews.llvm.org/D61600