[PATCH] D62718: [llvm-objcopy] Change output file permissions to be the same as the input file

[Alex Brachet via Phabricator via llvm-commits]

abrachet marked 2 inline comments as done.
abrachet added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:47
 #include <string>
+#include <sys/stat.h>
 #include <system_error>
----------------
Weird place for me to put this include, not really sure why I choose there. Regardless I am expecting this to change.


================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:188
 
+static bool isExecutableObject(object::Binary &Binary) {
+  if (auto *ELFObj = dyn_cast<object::ELFObjectFileBase>(&Binary))
----------------
This may not be permanent, I am trying to add ObjectFile::isExecutableObject() here https://reviews.llvm.org/D62838


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62718/new/

https://reviews.llvm.org/D62718