[PATCH] D62837: [LLD][COFF] Don't take into account the 'age' when looking for PDB type server

[Alexandre Ganea via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL362572: [LLD][COFF] Don't take into account the 'age' when looking for PDB type server (authored by aganea, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D62837?vs=203045&id=203055#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62837/new/

https://reviews.llvm.org/D62837

Files:
  lld/trunk/COFF/DebugTypes.cpp
  lld/trunk/test/COFF/Inputs/pdb-type-server-valid-signature.yaml


Index: lld/trunk/COFF/DebugTypes.cpp
===================================================================
--- lld/trunk/COFF/DebugTypes.cpp
+++ lld/trunk/COFF/DebugTypes.cpp
@@ -198,9 +198,9 @@
   pdb::InfoStream &Info = cantFail(PDBFile.getPDBInfoStream());
 
   // Just because a file with a matching name was found doesn't mean it can be
-  // used. The GUID and Age must match between the PDB header and the OBJ
+  // used. The GUID must match between the PDB header and the OBJ
   // TypeServer2 record. The 'Age' is used by MSVC incremental compilation.
-  if (Info.getGuid() != TS.getGuid() || Info.getAge() != TS.getAge())
+  if (Info.getGuid() != TS.getGuid())
     return createFileError(
         TS.Name,
         make_error<pdb::PDBError>(pdb::pdb_error_code::signature_out_of_date));
Index: lld/trunk/test/COFF/Inputs/pdb-type-server-valid-signature.yaml
===================================================================
--- lld/trunk/test/COFF/Inputs/pdb-type-server-valid-signature.yaml
+++ lld/trunk/test/COFF/Inputs/pdb-type-server-valid-signature.yaml
@@ -69,7 +69,7 @@
       - Kind:            LF_TYPESERVER2
         TypeServer2:
           Guid:            '{8DABD2A0-28FF-CB43-9BAF-175B77B76414}'
-          Age:             1
+          Age:             18
           Name:            'pdb-diff-cl.pdb'
   - Name:            '.text$mn'
     Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62837.203055.patch
Type: text/x-patch
Size: 1450 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190605/5ebaa093/attachment.bin>