[PATCH] D62766: [Attributor] Deduce "nosync" function attribute.

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 14:06:08 PDT 2019


sstefan1 marked an inline comment as done and an inline comment as not done.
sstefan1 added a comment.

Does everything else look ok?



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:418
   default:
-    return AtomicOrdering::NotAtomic;
+    Ordering = AtomicOrdering::NotAtomic;
+
----------------
jdoerfert wrote:
> Shouldn't we here directly assume sync as it is atomic but we don't know what kind?
Yes, my bad. I'll return true.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62766/new/

https://reviews.llvm.org/D62766





More information about the llvm-commits mailing list