[PATCH] D61934: [SCEV] Use wrap flags in InsertBinop

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: lib/Analysis/ScalarEvolutionExpander.cpp:193
+      // Conservatively, do not use any instruction which has any of exact
       // flags installed.
+      auto canGenerateIncompatiblePoison = [&Flags](Instruction *I) {
----------------
I'd move the comment down to the corresponding branch.


================
Comment at: lib/Analysis/ScalarEvolutionExpander.cpp:865
                          ConstantInt::get(Ty, RHS.logBase2()),
-                         /*IsSafeToHoist*/ true);
+                         SCEV::FlagNW, /*IsSafeToHoist*/ true);
   }
----------------
Should be FlagAnyWrap?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61934/new/

https://reviews.llvm.org/D61934