[PATCH] D62787: [X86] Add the vector integer min/max instructions to isAssociativeAndCommutative.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

I didn't review all of the test diffs, but all of the ones that I did look at are regressions. I agree that this is MachineCombiner's fault when a CPU model is absent and independent of this particular code change, but I think we should adjust the test files to either include a CPU model across the board or include an extra RUN line with and without a CPU model (could split off some subset of these tests into separate files so we're not wasting test time on every variation of these patterns). That way, we'll have some dedicated MachineCombiner test coverage and know more easily if something breaks/changes in there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62787/new/

https://reviews.llvm.org/D62787