[PATCH] D62361: [FastISel] Skip creating unnecessary vregs for arguments

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 11:07:01 PDT 2019


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:503
+  // Replace forward-declared registers with the registers containing
+  // the desired value.
+  MachineRegisterInfo &MRI = MF->getRegInfo();
----------------
I think it would be helpful if here you also augment the comment with an explanation (based on the patch description) for why this is done before the call to EmitLiveInCopies below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62361/new/

https://reviews.llvm.org/D62361





More information about the llvm-commits mailing list