[PATCH] D62853: Read .note.gnu.property sections and emit a merged .note.gnu.property section.

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 09:05:36 PDT 2019


peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

Thanks very much for extracting the .note.gnu.property parsing code. There was one modification I'd made in D62609 <https://reviews.llvm.org/D62609> that permitted multiple GNU_PROPERTY_X86_FEATURE_1_AND properties in the same .note.gnu.property section as this was observed in the ld.bfd testsuite. I'll submit a patch with just these modifications in.

One thing to mention here is that we may want to give a warning that IBT support is not implemented yet as this could result in a output that would fault (claims support via GNU_PROPERTY_X86_FEATURE_1_IBT) should anyone try to use it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62853/new/

https://reviews.llvm.org/D62853





More information about the llvm-commits mailing list