[PATCH] D62272: [LoopUtils][SLPVectorizer] clean up management of fast-math-flags
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 4 06:45:59 PDT 2019
spatel marked an inline comment as done.
spatel added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6298
+ if (!IsPairwiseReduction) {
+ // FIXME: The builder should already have an FMF guard, and this should
+ // not be hard-coded to 'fast'.
----------------
vporpo wrote:
> If I am not mistaken, the flags are set to 'fast' by `tryToReduce()` line 6111. So maybe it is better to check them with an assert() ?
Yes, that should be a good intermediate step until we can get this cleaned up properly.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62272/new/
https://reviews.llvm.org/D62272
More information about the llvm-commits
mailing list