[PATCH] D62275: [llvm-objdump] Add warning if --disassemble-functions specifies an unknown symbol
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 4 06:41:15 PDT 2019
MaskRay added inline comments.
================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1413
+ set_difference(DisasmFuncsSet, FoundDisasmFuncsSet);
+ if (!MissingDisasmFuncsSet.empty())
+ for (StringRef MissingDisasmFunc : MissingDisasmFuncsSet.keys())
----------------
The `if (!MissingDisasmFuncsSet.empty())` is redundant.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62275/new/
https://reviews.llvm.org/D62275
More information about the llvm-commits
mailing list