[PATCH] D62851: [llvm-objdump/llvm-readobj/obj2yaml/yaml2obj] Support DT_PPC_GOT and DT_PPC_OPT

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objdump/elf-dynamic-section-machine-specific.test:69
 
-# Test that PPC64 machine-specific tags can be dumped.
+## Test that PPC machine-specific tags can be dumped.
 # RUN: yaml2obj --docnum=3 -o %t.ppc \
----------------
If you're adding the extra '#' here, please also add it to the other cases in this file.


================
Comment at: test/tools/llvm-objdump/elf-dynamic-section-machine-specific.test:78
+# PPC-NEXT:   <unknown:>0x1234abcd 0x00000001
+#
+
----------------
Delete this line (or at least the '#')


================
Comment at: test/tools/llvm-readobj/elf-dynamic-tags-machine-specific.test:135
 
+# Test that PPC32 machine-specific tags can be dumped.
+# RUN: yaml2obj --docnum=3 %S/Inputs/elf-dynamic-tags-machine-specific.yaml -o %t.ppc32
----------------
PPC32 -> PPC?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62851/new/

https://reviews.llvm.org/D62851