[PATCH] D62851: [llvm-objdump/llvm-readobj/obj2yaml/yaml2obj] Support DT_PPC_GOT and DT_PPC_OPT

Tue Jun 4 05:57:05 PDT 2019

MaskRay marked an inline comment as done.
MaskRay added inline comments.

================
Comment at: test/tools/llvm-readobj/Inputs/elf-dynamic-tags-machine-specific.yaml:185-187
+      - Tag:   DT_PPC_GOT
+        Value: 0x200c0
+      - Tag:   DT_PPC_OPT
----------------
jhenderson wrote:
> Should you add these two tags to the 64-bit PPC rather than create another document? It seems odd having the two different variations.
I have to add a new document. ppc32 and ppc64 have different `e_machine` values. The two tags are not available on ppc64. Actually, there is a conflict:`DT_PPC64_GLINK == DT_PPC_GOT`. 

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62851/new/

https://reviews.llvm.org/D62851