[PATCH] D62840: [ELF] Suppress "STT_SECTION symbol should be defined" on .eh_frame, .debug*, .zdebug* and .gcc_except_table

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 05:20:09 PDT 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/InputSection.cpp:447-448
+          Elf_Shdr_Impl<ELFT> Sec =
+              CHECK(File->getObj().sections(),
+                    File)[cast<Undefined>(Sym).DiscardedSecIdx];
+          warn("relocation refers to a discarded section: " +
----------------
There is a newline in a little bit weird place. Is this what clang-format formatted?

Maybe you should write this using two assignments rather than writing it as a single line.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62840/new/

https://reviews.llvm.org/D62840





More information about the llvm-commits mailing list