[PATCH] D62784: [NFC] Include short string attributes in the "Function Attrs" comment

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

This change seems kind of arbitrary to me. Not all attributes that we might want to test for are shorter than 15 characters. Some are already longer and they can't be changed because of bitcode compatibility.

If the goal is to make things involving attributes more easily testable, why not work towards that goal directly? For example, you could add a flag that means "print all attribute names/values in the comment" and then use that in your tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62784/new/

https://reviews.llvm.org/D62784