[PATCH] D62433: [ObjC][ARC] Delete ObjC runtime calls if the argument is a global variable
Akira Hatanaka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 3 16:15:27 PDT 2019
ahatanak added a comment.
In D62433#1520061 <https://reviews.llvm.org/D62433#1520061>, @gottesmm wrote:
> I don't remember. That being said, this should be a conservative optimization. What if someone adds in the future a different global where this isn't a no-op. Is it possible if you know what the global is to add a whitelist that you only care about those 2 things.
I agree we should be conservative here, so I made it check the presence of "arc_retain_agnostic" on the global. I'll post a clang patch that adds the attribute to the globals shortly.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62433/new/
https://reviews.llvm.org/D62433
More information about the llvm-commits
mailing list