[PATCH] D62819: [SCCP] Add UnaryOperator visitor to SCCP

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 13:06:32 PDT 2019


fhahn added inline comments.


================
Comment at: llvm/test/Transforms/SCCP/apfloat-basictest.ll:4
+
+; RUN: opt < %s -sccp -S | not grep fneg
+
----------------
I think it would be better to explicitly check the return value, instead of relying on `grep`. Also, would it be possible to add another case where the operand to fneg itself needs to be propagated before we simplify fneg?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62819/new/

https://reviews.llvm.org/D62819





More information about the llvm-commits mailing list