[PATCH] D62819: [SCCP] Add UnaryOperator visitor to SCCP
Cameron McInally via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 3 11:50:57 PDT 2019
cameron.mcinally updated this revision to Diff 202767.
cameron.mcinally added a comment.
Fix comment: Binary->Unary.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62819/new/
https://reviews.llvm.org/D62819
Files:
llvm/lib/Transforms/Scalar/SCCP.cpp
llvm/test/Transforms/SCCP/undef-resolve.ll
Index: llvm/test/Transforms/SCCP/undef-resolve.ll
===================================================================
--- llvm/test/Transforms/SCCP/undef-resolve.ll
+++ llvm/test/Transforms/SCCP/undef-resolve.ll
@@ -180,3 +180,11 @@
; CHECK-LABEL: @test11(
; CHECK: ret i32 0
}
+
+; Test unary ops
+define double @test12(double %x) {
+ %t = fneg double undef
+ ret double %t
+; CHECK-LABEL: @test12(
+; CHECK: double undef
+}
Index: llvm/lib/Transforms/Scalar/SCCP.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/SCCP.cpp
+++ llvm/lib/Transforms/Scalar/SCCP.cpp
@@ -613,6 +613,7 @@
void visitCastInst(CastInst &I);
void visitSelectInst(SelectInst &I);
+ void visitUnaryOperator(Instruction &I);
void visitBinaryOperator(Instruction &I);
void visitCmpInst(CmpInst &I);
void visitExtractValueInst(ExtractValueInst &EVI);
@@ -969,6 +970,29 @@
markOverdefined(&I);
}
+// Handle Unary Operators.
+void SCCPSolver::visitUnaryOperator(Instruction &I) {
+ LatticeVal VState = getValueState(I.getOperand(0));
+
+ LatticeVal &IV = ValueState[&I];
+ if (IV.isOverdefined()) return;
+
+ if (VState.isConstant()) {
+ Constant *C = ConstantExpr::get(I.getOpcode(), VState.getConstant());
+
+ // op Y -> undef.
+ if (isa<UndefValue>(C))
+ return;
+ return (void)markConstant(IV, &I, C);
+ }
+
+ // If something is undef, wait for it to resolve.
+ if (!VState.isOverdefined())
+ return;
+
+ markOverdefined(&I);
+}
+
// Handle Binary Operators.
void SCCPSolver::visitBinaryOperator(Instruction &I) {
LatticeVal V1State = getValueState(I.getOperand(0));
@@ -1484,6 +1508,8 @@
else
markOverdefined(&I);
return true;
+ case Instruction::FNeg:
+ break; // fneg undef -> undef
case Instruction::ZExt:
case Instruction::SExt:
case Instruction::FPToUI:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62819.202767.patch
Type: text/x-patch
Size: 1909 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190603/3d9f2d48/attachment.bin>
More information about the llvm-commits
mailing list