[PATCH] D62711: [MACHO] Replaced calls to getStruct with getStructOrErr in functions returning Error or Expected or similar

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 08:42:37 PDT 2019


jhenderson added inline comments.


================
Comment at: llvm/lib/Object/MachOObjectFile.cpp:935
                           " LC_LINKER_OPTION cmdsize too small");
-  MachO::linker_option_command L =
-    getStruct<MachO::linker_option_command>(Obj, Load.Ptr);
+  auto LinkOptionOrErr = getStructOrErr<MachO::linker_option_command>(Obj, Load.Ptr);
+  if (!LinkOptionOrErr)
----------------
This line needs clang-formatting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62711/new/

https://reviews.llvm.org/D62711





More information about the llvm-commits mailing list