[PATCH] D60785: [ELF] Align file offset for .bss if first section in a PT_LOAD

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/linkerscript/bss-middle-align.test:4
+# RUN: ld.lld -o %t.exe --script %s %t.o
+# RUN: llvm-readelf -section-headers -program-headers %t.exe | FileCheck %s
+
----------------
For llvm-readelf, `--long-option` is now more common (GNU readelf parses `-long-option` as a list of short options).


================
Comment at: lld/test/ELF/linkerscript/bss-middle-align.test:8
+  .text : {
+    *(.text)
+  }
----------------
I think most other linkerscript tests write this on one line: `.text : { *(.text) }`. It is concise and more readable in my opinion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60785/new/

https://reviews.llvm.org/D60785