[PATCH] D62768: [ELF] Don't create an output section named `/DISCARD/` if it is assigned to the special phdr `NONE`

[Andrew Ng via Phabricator via llvm-commits]

andrewng added a comment.

> If I read correctly, this is to assign `/DISCARD` to the memory region `rodata` and expect `.rodata` to inherit the memory region?
> 
> Sorry I didn't follow the discussion in D61186 <https://reviews.llvm.org/D61186> and didn't notice D61251 <https://reviews.llvm.org/D61251>. It seems @grimar and @peter.smith were fine with D61251 <https://reviews.llvm.org/D61251> (this patch is essentially D61251 <https://reviews.llvm.org/D61251>). @andrewng if you are ok with letting this somewhat contrived example fail, we can probably still mark this as resolved (wontfix).

I'm OK with this unusual test case failing, if everyone else is fine with it too. It was just something I came across whilst creating D61186 <https://reviews.llvm.org/D61186> and was why I didn't take this approach with isDiscardable.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62768/new/

https://reviews.llvm.org/D62768