[llvm] r362404 - [llvm] [test] Remove non-portable EISDIR test from macho-disassemble-g-dsym.test
Michal Gorny via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 3 07:50:04 PDT 2019
Author: mgorny
Date: Mon Jun 3 07:50:03 2019
New Revision: 362404
URL: http://llvm.org/viewvc/llvm-project?rev=362404&view=rev
Log:
[llvm] [test] Remove non-portable EISDIR test from macho-disassemble-g-dsym.test
Remove the test checking error message for 'is a directory'. It does
not seem to serve any real purpose, and it relies on matching platform
error strings which are unpredictable and makes the test fragile.
Furthermore, it fails on NetBSD where read() works on directories,
and therefore does not return EISDIR at all.
Fixes r362141.
Differential Revision: https://reviews.llvm.org/D62773
Modified:
llvm/trunk/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test
Modified: llvm/trunk/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test?rev=362404&r1=362403&r2=362404&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test (original)
+++ llvm/trunk/test/tools/llvm-objdump/X86/macho-disassemble-g-dsym.test Mon Jun 3 07:50:03 2019
@@ -15,8 +15,3 @@ MACHO_DSYM: (__TEXT,__text) section
// RUN: llvm-objdump -m -d -g -dsym %p/../Inputs/libbogus11.a %p/../../dsymutil/Inputs/basic.macho.x86_64 2>&1 | FileCheck -check-prefix BAD_INPUT %s
BAD_INPUT: is not a Mach-O or Universal file type.
-
-// RUN: not llvm-objdump -m -d -g -dsym %p/Inputs %p/Inputs/hello-macho-thin 2>&1 | FileCheck -check-prefix DIRECTORY %s
-
-// Windows will emit "Is a directory", whereas others emit "is a directory"
-DIRECTORY: {{[i|I]}}s a directory
More information about the llvm-commits
mailing list