[PATCH] D62773: [llvm] [test] Remove non-portable EISDIR test from macho-disassemble-g-dsym.test

[Michael Trent via Phabricator via llvm-commits]

mtrent accepted this revision.
mtrent added a comment.

Given the problems we've seen with windows and netbsd, I think it makes sense for llvm-obdump to have a better, more bespoke error case, one that is stable on all platforms. so let's pull this test.

Should llvm-objdump allow arbitrary directories to be passed into the -dsym flag? No. And I have no idea what error netbsd actually fails with here. Arguably it should allow .dSYM bundle directories; and that would also obviate a need for this exact test (to be replaced with other error tests for malformed .dSYM bundles, unreadable plist files, etc.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62773/new/

https://reviews.llvm.org/D62773