[PATCH] D62806: [X86] X86DAGToDAGISel::matchBitExtract(): pattern c: truncation awareness

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:3050
   // Match potentially-truncated (bitwidth - y)
-  auto matchShiftAmt = [checkOneUse, Size, &NBits](SDValue ShiftAmt) {
+  auto matchShiftAmt = [checkOneUse, &NBits](SDValue ShiftAmt,
+                                             unsigned Bitwidth) {
----------------
RKSimon wrote:
> Inconsistent - checkOneUse or &checkOneUse ?
Hm, indeed. I guess since no one complained thus far both variants are ok.
This problem is all over this function, so i'd rather fix it as a follow-up,
but i'm not sure in which direction it should be fixed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62806/new/

https://reviews.llvm.org/D62806