[PATCH] D40554: [PowerPC] Fix bugs in sign-/zero-extension elimination

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:3848
+    auto SrcExt = isSignOrZeroExtended(SrcReg, BinOpDepth, MRI);
+    return std::pair<bool,bool>(SrcExt.first | IsSExt, SrcExt.second | IsZExt);
   }
----------------
The bitwise or seems like an odd choice here since `IsSExt/IsZExt` shouldn't possibly be `true` here and also I think logical or seems more natural for `bool` variables.
The change to logical or doesn't require another revision.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:3859
+    auto SrcExt = isSignOrZeroExtended(SrcReg, BinOpDepth, MRI);
+    return std::pair<bool,bool>(SrcExt.first | IsSExt, SrcExt.second | IsZExt);
+  }
----------------
These can probably be logical or's as well. Same with the below ones.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:3901
+      if (!MI->getOperand(I).isReg()) {
+        // todo: Handle isImm()
+        return std::pair<bool,bool>(false, false);
----------------
Please remove this `todo`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D40554/new/

https://reviews.llvm.org/D40554