[PATCH] D62604: [CodeGen] Generic Hardware Loop Support

[Markus Lavin via Phabricator via llvm-commits]

markus added inline comments.


================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:462
+    IntegerType *CountType    = nullptr;
+    Value *NumElements        = nullptr;  // The maximum number of elements
+                                          // processed in the loop body.
----------------
Is `NumElements` really required by the initial commit that only adds the loop intrinsics?


================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:468
+                                          // in the loop via a phi?
+    bool RequiresNewPreheader = false;
+  };
----------------
I find this confusing. I understand that a preheader is required for the transformation (because that is where the `llvm.set.loop.iterations` is inserted) but why would an additional/new preheader ever be needed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62604/new/

https://reviews.llvm.org/D62604