[PATCH] D62371: [llvm-symbolizer] Flush output on bad input

[James Henderson via Phabricator via llvm-commits]

jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: test/tools/llvm-symbolizer/Inputs/flush-output.py:8
+    process.kill()
+    sys.exit(1)
+
----------------
ikudrin wrote:
> It looks like when `process.kill()` is executed, the main thread stops waiting, processes the rest and exits with the exit status `0`.
> 
> [[ https://docs.python.org/3/library/sys.html#sys.exit | The python documentation]] says:
> > Since exit() ultimately “only” raises an exception, it will only exit the process when called from the main thread, and the exception is not intercepted.
I'm not sure what you're asking me to do here? This code causes llvm-symbolizer to end, rather than continuing to hang, and then the python script exits.

For reference, I verified that the test fails and only hangs for 20 seconds as expected, without the bug fix, and passes with the bug fix.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62371/new/

https://reviews.llvm.org/D62371