[PATCH] D62482: Sanitize llvm-size help

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 03:57:10 PDT 2019


jhenderson added a comment.

Mostly looks good, but one small comment.



================
Comment at: llvm/tools/llvm-size/llvm-size.cpp:99-101
+static cl::list<std::string> InputFilenames(cl::Positional,
+                                            cl::desc("<input files>"),
+                                            cl::ZeroOrMore, cl::cat(SizeCat));
----------------
Is the option category needed on positional arguments? That surprises me slightly, since it doesn't directly appear in the help text.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62482/new/

https://reviews.llvm.org/D62482





More information about the llvm-commits mailing list