[PATCH] D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC.

pierre gousseau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 03:11:02 PDT 2019


pgousseau added a comment.

In D62245#1526733 <https://reviews.llvm.org/D62245#1526733>, @jdoerfert wrote:

> I think adding all these comments and updating the format is a great thing!
>
> Minor comments to consider:
>
> - I thought we used backslash instead of @ now but I might be wrong. The coding standard uses backslashs, if compiler-rt is not using @ all over the place you should change it.
> - Mention in the commit message that you also add descriptions to undocumented functions.
> - Mention in the commit message that you improved spelling, grammar, and formatting as well.
>
>   I'm not a compiler-rt person but if there is no objection in the next few days, you should go ahead (LGTM).


Sounds good, yes '@' is not used at all in compiler-rt doxygen comments, I have replaced with '\'. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62245/new/

https://reviews.llvm.org/D62245





More information about the llvm-commits mailing list