[PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

Tom Tan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 2 17:53:54 PDT 2019


TomTan added a comment.

In D62772#1526824 <https://reviews.llvm.org/D62772#1526824>, @compnerd wrote:

> This should get the build working again, so lets get this fixed, we can improve it later


Thanks, committed the fix to unblock build. For WoA(ARM32) which is not supported, I meant LLVM CodeView, not CodeView specification. `llvm::codeview::getRegisterNames(cpu_type)` will return incorrect register name even the right `CPUType` is passed in for WoA(ARM32), because it has not been implemented in LLVM CodeView yet.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62772/new/

https://reviews.llvm.org/D62772





More information about the llvm-commits mailing list