[PATCH] D62793: [X86] X86DAGToDAGISel::matchBitExtract(): pattern b: truncation awareness

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 2 13:46:07 PDT 2019


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2248
+/// MaskedValueIsAllOnes - Return true if '(Op & Mask) == Mask'.
+/// Mask is known to be zero for bits that V cannot have.
+bool SelectionDAG::MaskedValueIsAllOnes(SDValue V, const APInt &Mask,
----------------
Remove this line - its MaskedValueIsZero specific


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62793/new/

https://reviews.llvm.org/D62793





More information about the llvm-commits mailing list