[PATCH] D62101: NewGVN: Handle addrspacecast

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

This generally makes sense to me. I left a comment as it would be preferable to split the two conceptual changes if we can test them separately.
I think we also need `addrspacecast` tests with different address spaces to show they are not accidentally merged.



================
Comment at: lib/Transforms/Scalar/NewGVN.cpp:1181
+
+  if (AllConstant) {
     // We don't bother trying to simplify unless all of the operands
----------------
The way I understand this: If you have a BitCast, or maybe even another instruction, for which the simplify failed but `AllConstant` is true, you won't get constant folding before, correct?

Would it be possible to show the problem even w/o AddrSpaceCast?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62101/new/

https://reviews.llvm.org/D62101