[PATCH] D62245: [compiler-rt] Update comments in asan header to doxygen format; NFC.
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 2 11:42:11 PDT 2019
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
I think adding all these comments and updating the format is a great thing!
Minor comments to consider:
- I thought we used backslash instead of @ now but I might be wrong. The coding standard uses backslashs, if compiler-rt is not using @ all over the place you should change it.
- Mention in the commit message that you also add descriptions to undocumented functions.
- Mention in the commit message that you improved spelling, grammar, and formatting as well.
I'm not a compiler-rt person but if there is no objection in the next few days, you should go ahead (LGTM).
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
More information about the llvm-commits