[PATCH] D62718: [llvm-objcopy] Change output file permissions to be the same as the input file
Alex Brachet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 2 09:51:54 PDT 2019
abrachet marked 3 inline comments as done.
abrachet added inline comments.
Comment at: llvm/test/tools/llvm-objcopy/ELF/same-permissions.test:2
+# RUN: llvm-objcopy %p/Inputs/alloc-symtab.o %t
+# RUN: stat --printf=%a %p/Inputs/alloc-symtab.o > %t1
+# RUN: stat --printf=%a %t > %t2
> Actually does stat work like this on windows? Try and confirm before landing so that you don't have to revert.
I don't believe it will work on Windows, hopefully the requires system-linux is ok but if not we can just remove the test case
Comment at: llvm/test/tools/llvm-objcopy/ELF/strip-all-and-remove.test:2
# RUN: yaml2obj %s > %t
-# RUN: cp %t %t1
+# RUN: cp -p %t %t1
I was having some permissions problems with %t1 so I am just preserving %t's permissions
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits