[PATCH] D62783: [DAG] isBitwiseNot / isConstOrConstSplat - add support for build vector undefs + truncation (PR41020)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 2 03:01:55 PDT 2019


RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:8667
+      EVT NSVT = N.getValueType().getScalarType();
+      if ((CVT == NSVT) || (AllowTruncation && CVT.bitsGE(NSVT)))
+        return CN;
----------------
nikic wrote:
> `CVT.bitsGE(NSVT)` should be an assertion, it holds for all build_vectors.
Nice catch!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62783/new/

https://reviews.llvm.org/D62783





More information about the llvm-commits mailing list