[lld] r362314 - [ELF][MIPS] Delete dead !Sym->isDefined() check in addAbsolute()

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 1 19:43:38 PDT 2019


Author: maskray
Date: Sat Jun  1 19:43:38 2019
New Revision: 362314

URL: http://llvm.org/viewvc/llvm-project?rev=362314&view=rev
Log:
[ELF][MIPS] Delete dead !Sym->isDefined() check in addAbsolute()

Modified:
    lld/trunk/ELF/Writer.cpp

Modified: lld/trunk/ELF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=362314&r1=362313&r2=362314&view=diff
==============================================================================
--- lld/trunk/ELF/Writer.cpp (original)
+++ lld/trunk/ELF/Writer.cpp Sat Jun  1 19:43:38 2019
@@ -188,8 +188,6 @@ static Defined *addOptionalRegular(Strin
 static Defined *addAbsolute(StringRef Name) {
   Symbol *Sym = Symtab->addSymbol(Defined{nullptr, Name, STB_GLOBAL, STV_HIDDEN,
                                           STT_NOTYPE, 0, 0, nullptr});
-  if (!Sym->isDefined())
-    error("duplicate symbol: " + toString(*Sym));
   return cast<Defined>(Sym);
 }
 




More information about the llvm-commits mailing list