[llvm] r362301 - [APInt] Add PR40897 test case

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 1 07:58:36 PDT 2019


Author: rksimon
Date: Sat Jun  1 07:58:36 2019
New Revision: 362301

URL: http://llvm.org/viewvc/llvm-project?rev=362301&view=rev
Log:
[APInt] Add PR40897 test case

In reality APInt::getBitsNeeded(INT_MIN, base) cases require one less bit than is returned

Modified:
    llvm/trunk/unittests/ADT/APIntTest.cpp

Modified: llvm/trunk/unittests/ADT/APIntTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/APIntTest.cpp?rev=362301&r1=362300&r2=362301&view=diff
==============================================================================
--- llvm/trunk/unittests/ADT/APIntTest.cpp (original)
+++ llvm/trunk/unittests/ADT/APIntTest.cpp Sat Jun  1 07:58:36 2019
@@ -1262,6 +1262,9 @@ TEST(APIntTest, StringBitsNeeded10) {
   EXPECT_EQ(5U, APInt::getBitsNeeded("-10", 10));
   EXPECT_EQ(6U, APInt::getBitsNeeded("-19", 10));
   EXPECT_EQ(6U, APInt::getBitsNeeded("-20", 10));
+
+  // TODO: INT_MIN cases need 1 less bit (PR40897)
+  EXPECT_EQ(9U, APInt::getBitsNeeded("-128", 10));
 }
 
 TEST(APIntTest, StringBitsNeeded16) {




More information about the llvm-commits mailing list