[PATCH] D62687: [Attributor] Deduce "nofree" function attribute

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 1 00:52:10 PDT 2019

jdoerfert added a comment.

In D62687#1526078 <https://reviews.llvm.org/D62687#1526078>, @uenoku wrote:

> > The test changes are still missing.
> Oh, I missed it. I'm now writing this but I'm in trouble.
> In D62313 <https://reviews.llvm.org/D62313>, you said that it is preferable to write a test like this:
>   ; CHECK:       Function Attrs: noinline norecurse nounwind readnone uwtable
>   ; CHECK-NEXT:     define double* @ret_undef_arg_undef(i32* readnone %b)
> However, I think this format would not work for string attribute, isn't it?

I honestly do not know, if it is not, you need to choose a way that works. If you find that difficult, let me know. (Do not delete the checks but remove the CHECK part or rename it).



More information about the llvm-commits mailing list