[PATCH] D62698: [GWP-ASan] Configuration options [3].

Vlad Tsyrklevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 20:51:04 PDT 2019

vlad.tsyrklevich added inline comments.

Comment at: compiler-rt/lib/gwp_asan/optional/options_parser.cpp:60
+  if (!o->Enabled)
+    return;
morehouse wrote:
> hctim wrote:
> > morehouse wrote:
> > > Should we return early?  Maybe the user will later set `Enabled = true`.  In that case, we skipped the below validation and `Printf` initialization.
> > I don't think we should be targeting live-enable/disable of GWP-ASan at this point in time, only at start time, unless I misunderstand the premise of the question.
> > 
> > @vlad.tsyrklevich WDYT?
> In that case, why support modifying options at runtime at all?
> `getOptions` should return a const-ref, not a pointer and all initialization should be done through `initOptions`.
Agree that live-enable/disable doesn't really make sense, and that we should change the interface to be a const ref instead.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list