[PATCH] D62358: [SimplifyLibCalls] Fold more fortified builtin functions into their non-fortified variants when possible

[Erik Pilkington via Phabricator via llvm-commits]

erik.pilkington marked 7 inline comments as done.
erik.pilkington added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/BuildLibCalls.h:109
 
+  Value *emitMemCCpy(Value *Ptr1, Value *Ptr2, Value *Val, Value *Len,
+                     IRBuilder<> &B, const TargetLibraryInfo *TLI);
----------------
jdoerfert wrote:
> Any reason you didn't add comments here?
> 
No reason, I added them in the commit.


================
Comment at: llvm/include/llvm/Transforms/Utils/SimplifyLibCalls.h:74
   /// to the non-fortified version.
+  ///
+  /// \param SizeOp optionally set to the parameter index of an explicit buffer
----------------
jdoerfert wrote:
> When you add parameter descriptions, could you add it for all five parameters?
Sure, done.


================
Comment at: llvm/lib/Transforms/Utils/BuildLibCalls.cpp:792
 
+static Value *emitLibCall(LibFunc TheLibFunc, Type *ReturnType,
+                          ArrayRef<Type *> ParamTypes,
----------------
jdoerfert wrote:
> This can be commited separately.
Sure, done in r362271. Thanks for reviewing!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62358/new/

https://reviews.llvm.org/D62358