[PATCH] D62358: [SimplifyLibCalls] Fold more fortified builtin functions into their non-fortified variants when possible
Erik Pilkington via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 31 15:39:41 PDT 2019
erik.pilkington marked 7 inline comments as done.
erik.pilkington added inline comments.
Comment at: llvm/include/llvm/Transforms/Utils/BuildLibCalls.h:109
+ Value *emitMemCCpy(Value *Ptr1, Value *Ptr2, Value *Val, Value *Len,
+ IRBuilder<> &B, const TargetLibraryInfo *TLI);
> Any reason you didn't add comments here?
No reason, I added them in the commit.
Comment at: llvm/include/llvm/Transforms/Utils/SimplifyLibCalls.h:74
/// to the non-fortified version.
+ /// \param SizeOp optionally set to the parameter index of an explicit buffer
> When you add parameter descriptions, could you add it for all five parameters?
Comment at: llvm/lib/Transforms/Utils/BuildLibCalls.cpp:792
+static Value *emitLibCall(LibFunc TheLibFunc, Type *ReturnType,
+ ArrayRef<Type *> ParamTypes,
> This can be commited separately.
Sure, done in r362271. Thanks for reviewing!
CHANGES SINCE LAST ACTION
More information about the llvm-commits