[PATCH] D62753: [llvm-lipo] Implement -archs

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:227
+  else
+    llvm_unreachable("Unexpected binary format");
+
----------------
smeenai wrote:
> compnerd wrote:
> > I don't think that this is necessarily unreachable - an invalid binary being given to the tool could hit this.  This should be a proper error.
> `readInputBinaries` above should have ensured we have a binary in the correct format.
i think here llvm_unreachable is appropriate since it should have been checked earlier, so here it's just a defensive assert (rather than do the same check and error reporting in multiple places)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62753/new/

https://reviews.llvm.org/D62753