[PATCH] D62753: [llvm-lipo] Implement -archs
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 31 15:38:58 PDT 2019
alexshap added inline comments.
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:227
+ llvm_unreachable("Unexpected binary format");
> compnerd wrote:
> > I don't think that this is necessarily unreachable - an invalid binary being given to the tool could hit this. This should be a proper error.
> `readInputBinaries` above should have ensured we have a binary in the correct format.
i think here llvm_unreachable is appropriate since it should have been checked earlier, so here it's just a defensive assert (rather than do the same check and error reporting in multiple places)
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits