[PATCH] D62753: [llvm-lipo] Implement -archs
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 31 15:32:34 PDT 2019
alexshap added inline comments.
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:154
+ llvm_unreachable("llvm-lipo action unspecified");
> compnerd wrote:
> > I don't think that this should be unreachable - if the action is unspecified, that can occur normally in the way that the user invokes the tool. Perhaps this should be a proper error?
> Lines 123 through 133 should ensure we have a single action argument of the expected type. My switch statement suggestion above should make that structure clearer.
llvm_unreachable is for internal logical errors, here if the specified command line arguments are incorrect we should make use of reportError, the tool should not crash.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the llvm-commits